Repository navigation
feat: add Battle Revolution save support - #69
Open
NewBarkTownKris wants to merge 1 commit into
Open
NewBarkTownKris wants to merge 1 commit into
NewBarkTownKris wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dolphin discovery skips Battle Revolution's Wii save, and the existing parser
opens only the default profile. Add raw PbrSaveData discovery and a Storage
profile picker so players can browse and edit all four profiles.
The change uses the pinned SAV4BR/BK4 parser, corrects profile trainer names,
and makes write checks compare every profile before a backup or write. Profile
selection preserves the whole-file baseline, failed-write recovery retains the
selected profile, and connected transfer previews use that same profile.
Validation:
Japanese: 28 profiles, 11,897 occupied records, 88 isolated nickname edits,
native exports, no-op equality, corruption and preservation checks. Saves
and ROMs are not included in the PR.
all profile views and party-edit reloads tested. A nickname edit survived a
cold game boot, in-game save and full reload. The final diagnostic APK was
installed and started with vanilla PKForge still installed separately.
Wii data.bin archives are imported through Dolphin first. Dedicated battle-pass
editing and in-game testing of other regional releases are outside this change.
The pinned core cannot encode every profile name; names that cannot round-trip
are refused without changing the profile, while existing names are preserved.
Format references: pinned PKHeX SAV4BR
and BK4.