Skip to content

feat: add Battle Revolution save support - #69

Open
NewBarkTownKris wants to merge 1 commit into
sofianeelhor:devfrom
NewBarkTownKris:feat/battle-revolution-save-support
Open

NewBarkTownKris wants to merge 1 commit into
sofianeelhor:devfrom
NewBarkTownKris:feat/battle-revolution-save-support

Conversation

@NewBarkTownKris

Copy link
Copy Markdown

Dolphin discovery skips Battle Revolution's Wii save, and the existing parser
opens only the default profile. Add raw PbrSaveData discovery and a Storage
profile picker so players can browse and edit all four profiles.

The change uses the pinned SAV4BR/BK4 parser, corrects profile trainer names,
and makes write checks compare every profile before a backup or write. Profile
selection preserves the whole-file baseline, failed-write recovery retains the
selected profile, and connected transfer previews use that same profile.

Validation:

  • Release tests: 623 Domain and 981 Engine passed, including 28 PBR cases.
  • Release Android diagnostic build and publish passed with zero build warnings.
  • Seven private raw saves across English, German, Spanish, French, Italian and
    Japanese: 28 profiles, 11,897 occupied records, 88 isolated nickname edits,
    native exports, no-op equality, corruption and preservation checks. Saves
    and ROMs are not included in the PR.
  • AYN Thor (Android 13), Dolphin 2609a, USA RPBE01: GameCube/Wii discovery,
    all profile views and party-edit reloads tested. A nickname edit survived a
    cold game boot, in-game save and full reload. The final diagnostic APK was
    installed and started with vanilla PKForge still installed separately.

Wii data.bin archives are imported through Dolphin first. Dedicated battle-pass
editing and in-game testing of other regional releases are outside this change.
The pinned core cannot encode every profile name; names that cannot round-trip
are refused without changing the profile, while existing names are preserved.

Format references: pinned PKHeX SAV4BR
and BK4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant